PLTFRS-18353: Filter out non healthy on non in services instances from ASG #7
+81
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msangoi
reviewed
Oct 2, 2023
pkg/lookable/asg.go
Outdated
| instances := make([]*string, numInstances) | ||
| for i, inst := range resp2.AutoScalingGroups[0].Instances { | ||
| if (*inst.HealthStatus == "Healthy" && *inst.LifecycleState == "InService") { | ||
| instances[i] = inst.InstanceId |
There was a problem hiding this comment.
You created the instances slice with an initial length. Some elements will not be assigned and left with the default value (empty string). No issue when calling the DescribeInstances function with it?
You could have created an empty slice and append instances to it when they are healthy.
There was a problem hiding this comment.
should be better now
msangoi
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: